MediaWiki talk:Monobook.js

From Wikipedia, the free encyclopedia

Archives
June 2004 - July 2006

1 Main Page Hack
2 History and 'My Contributions'
3 Accesskey for project page
4 Popup table generator
5 Reference navbar
6 Default hide/show for NavFrame
7 oh no!
8 Helper function for user scripts
9 New buttons in edit toolbar
10 Table button
11 Archive
12 Page not found
13 addLoadEvent versus addOnloadHook
14 Toolbar extras
15 Firefox 2.0
16 Collapsible tables fix for IE
17 pl.wiki edit summaries
18 Initial letter is shown capitalized due to technical restrictions

[edit] Main Page Hack

For the main page hack that removes stuff on the main page, why not just use the page title mentioned in the HTML header of every page?

For example, this was on this page in the html sourcecode:

                <script type= "text/javascript">
                        var skin = "monobook";
                        var stylepath = "/skins-1.5";

                        var wgArticlePath = "/wiki/$1";
                        var wgScriptPath = "/w";
                        var wgServer = "http://en.wikipedia.org";
                        
                        var wgCanonicalNamespace = "MediaWiki_talk";
                        var wgPageName = "MediaWiki_talk:Monobook.js";
                        var wgTitle = "Monobook.js";
                        var wgArticleId = 725652;
                        
                        var wgUserName = "GeorgeMoney";
                        var wgUserLanguage = "en";
                        var wgContentLanguage = "en";
                </script>

GeorgeMoney (talk) 22:03, 4 August 2006 (UTC)

We in Kazakh wiki use like:

// BEGIN Remove weird mainPage titling
// var wgPageName - from global variables on HTML header of every page
var isMainPage = (wgPageName == "Main_Page");
var isDiff = (document.location.search && (document.location.search.indexOf("diff=") != -1 || document.location.search.indexOf("oldid=") != -1));

if (isMainPage && !isDiff) 
{
 document.write('<style type="text/css">/*<![CDATA[*/ #lastmod, #siteSub, #contentSub, h1.firstHeading { display: none !important; } /*]]>*/</style>');
}

//Main page tab no longer says article
function mainpg() {
      if ((isMainPage || /[\/=:]Main_Page/.test(document.location)) && document.getElementById('ca-nstab-main')) {
            document.getElementById('ca-nstab-main').firstChild.innerHTML = 'Main Page';
      }   
}
addOnloadHook(mainpg);

--AlefZet 11:17, 17 August 2006 (UTC)

[edit] History and 'My Contributions'

I'm not sure if this is the right place to report this, but the worst that can happen is someone will say 'This isn't the right place to post this'. Anyway, I'm using Internet Explorer 6, and the content boxes on the history pages, and 'My Contributions' are compressed so that I can't see the text. I'm wondering if this is a problem that everyone with Internet Explorer 6 gets, and if this is something that can be fixed here?--Jcvamp

[edit] Accesskey for project page

Please change ta['ca-nstab-wp'] = new Array('c','View the project page'); to ta['ca-nstab-project'] = new Array('c','View the project page');. That is the name of the Project tab. Thank you. --Thunderhead 09:21, 16 August 2006 (UTC)

Also, ca-article is the name for the Special page tab, not ca-nstab-special. --Thunderhead 09:24, 16 August 2006 (UTC)

Done, thanks for the note. -- Jitse Niesen (talk) 10:46, 16 August 2006 (UTC)

Thank you. --Thunderhead 15:33, 16 August 2006 (UTC)

[edit] Popup table generator

fr.wikipedia.org uses a nice hack in its monobook.js to add a toolbar button which opens a little popup window to ask for table dimensions, and to insert the table as wikitext into the edit box. Try it out by editing a page and clicking the table button (first from the left). Should we copy this idea?--Eloquence * 14:14, 25 August 2006 (UTC)

Well, if there is no objections to this, we should try it out. I do not see any harm in doing this as well. --S iva1979^{Talk to me} 05:25, 26 August 2006 (UTC)

Actually much of the stuff here[1] would be very useful for basic editing too.Voice-of-All 10:12, 26 August 2006 (UTC)

I've implemented all of these.Voice-of-All 19:13, 24 September 2006 (UTC)

[edit] Reference navbar

See [2]. Within these scripts there is also a simple script ("Reference divs") that makes the auto-generated references appear with a scrollbar so that they won't take up so much room. I'd like to add this here.Voice-of-All 10:05, 26 August 2006 (UTC)

[edit] Default hide/show for NavFrame

(following up from Wikipedia:Village pump (technical)#Template:Hidden - Auto Show/Hide)

I coded up a replacement for the createNavigationBarToggleButton function at MediaWiki:Monobook.js which allows one to specify if the box should be open or closed by default. It can be found at [3] if you want to check the code. Once it's added to Monobook.js (replacing the function already there), using NavFrameDefaultHide instead of NavFrame will force the box to be hidden by default, and using NavFrameDefaultShow instead of NavFrame will force the box to be shown by default. I intend to add the code to Monobook.js in a few days if nobody complains. --cesarb 16:59, 2 September 2006 (UTC)

Hold on. Two months ago I proposed a more general enhancement to the functionality of the navigation bars above; test code is here, sandbox here. My code is currently written with different class names. The idea was to allow alternate texts for the button (implemented with the "title" attribute), and to allow "inline" dynamic nav content. I would really like to see some work on getting this functionality implemented.

On defaults, I don't think it's a good idea to build the show-default into the name of the header class; in my test code I indicate a show-default through a separate class used in addition to the header class. Gimmetrow 17:58, 2 September 2006 (UTC)

Where the hell are the docs for all of the NavFrame stuff? I've been searching for about 45 minutes now. —Michael Z. 2006-10-31 04:01 Z

[edit] oh no!

The new "section 0 edit link" is really ugly and messes up alot of pages pushing text a long way. It is really obtrusive and messes with already installed scripts.

If you do want to add one please add it higher so it doesn't mess up anything else and remove that part from the monobook.css you can add it to the div's style.

Why not use Wikipedia:WikiProject User scripts/Scripts/Edit Top which is much better coded and more stable, and doesn't intrude.

This really messes everything up, especially userpages and some articles.

GeorgeMoney (talk) 01:21, 3 September 2006 (UTC)

OK, it was removed for now. Let's see what other people say. —Mets501 (talk) 01:32, 3 September 2006 (UTC)

Using an older version of Safari, this turned most article text smaller and gray, and also caused some sentences to look like a hyperlink (but when clicked they went nowhere). Seems better after the revert. Carl Lindberg 01:34, 3 September 2006 (UTC)

Yes, this new code created links in some odd places on some pages (in Safari 2.0.4). However, Edit Top, which I have been using, doesn't have a look consistent with the other edit tabs. I agree this should be part of the site software, however it also shouldn't be beta tested live on the site. I've been asking for two months to have my own codes tested and rolled in... Gimmetrow 01:46, 3 September 2006 (UTC)

I've tried the updated version of Edit Top and the edit tab seems to be consistent with the others on the page. The edit link is showing up on diff and history pages, however. Gimmetrow 03:53, 3 September 2006 (UTC)

Well, for reference, here is the old Edit Top script:

function edittop() {
  if(document.getElementById("wikiPreview") || window.location.href.indexOf("/wiki/Special:") != -1) return;
  var pageTitle = document.title.split(" - ")[0].replace(" ", "_"); 
  var divContainer = document.createElement("div");
  divContainer.innerHTML = '<div class="editsection" style="float:right;margin-left:5px;margin-right:15px;margin-top:3px;">[<a href="'+phpurl+pageTitle+'&action=edit&section=0" title="'+document.title.split(" - ")[0]+'">edit top</a>]</div>';
  if(window.location.href.indexOf("&action=edit") == -1)
    document.getElementById("content").insertBefore(divContainer, document.getElementsByTagName("h1")[0]);
  if(window.location.href.indexOf("&action=edit&section=0") != -1)
    document.getElementById("wpSummary").value = "/* Intro */ ";
};

GeorgeMoney (talk) 04:04, 3 September 2006 (UTC)

If people really want to do this, it should probably be on the right side of the page above the border-bottom for the headline for the section you will be editing, like the other section-edit edit links are. Personally I would never use it, but from answering help desk questions it does seem to be a point of confusion for at least a few people, some even thinking the top section was some locked section only editable by special people. - cohesion 17:46, 5 September 2006 (UTC)

[edit] Helper function for user scripts

I would like this funtion to be included so it's easier for users to include user scripts. —The preceding unsigned comment was added by AzaToth (talk • contribs) .

/*Takes the wikipage "page" and includes it's raw text as javascript.*/
function import_external(page){
    if( document.createElement && document.childNodes ) {
        var url = 
            'http://en.wikipedia.org/w/index.php?title=' + 
            page + 
            '&action=raw&ctype=text/javascript';
        var scriptElem = document.createElement('script');
        scriptElem.setAttribute('src',url);
        scriptElem.setAttribute('type','text/javascript');
        document.getElementsByTagName('head')[0].appendChild(scriptElem);
    }
}

I don't know, is this generally done for user scripts? The script would break on non-monobook skins, and there is no common site-wide local javascript. Would it be fine if users just added this helper script when they are using scripts that call it? —Mets501 (talk) 18:14, 21 September 2006 (UTC)
- I think {{subst:js}} covers this. I've seen following used when someone needs to include a lot of scripts. Gimmetrow 23:41, 21 September 2006 (UTC)

/*** [[User:Lightdarkness]]'s include function ***/
function inc (file) {
  var lt = String.fromCharCode(60);
  var gt = String.fromCharCode(62);
  document.writeln(lt+'script type="text/javascript" src="/w/index.php?title='+file+'&action=raw&ctype=text/javascript&dontcountme=s"'+gt+lt+'/script'+gt);
}

- Off course every one can include it in their own script, but it's more tedious, also most people are using code like the one gimmetrow showed, and that's non optimal in at least two ways. First it will need to be reparsed when written, it is much faster to include it directly in the DOM-tree, second, when using document.writeln, the output will be written to the end of the document, generating a non-compatible page (application/xhtml-xml will bail out on such code generally). _→AzaToth 23:55, 21 September 2006 (UTC)

[edit] New buttons in edit toolbar

Please revert the addition of a ton of extra buttons, if a user wants them they can add them themself but that is truely overkill, i also see no visible consensus asking users if they would like them. thanks/Fenton, Matthew Lexic Dark 52278 Alpha 771 19:17, 24 September 2006 (UTC)

This was brought up here a month ago, without objection. For such a visually minor change, I don't see the problem with adding some small buttons to the toolbar (and it is not bleeding over or anything). The vast majority of people who edit this site do not even know how to just "add them" or that they need an account, and they don't know javascript either. Some of these buttons are badly needed (ie table, which fr. has). Though perhaps a few could be shaved off just for the sake of simplicity.Voice-of-All 19:28, 24 September 2006 (UTC)

Digital_me plans to write a bit of disabling javascript, but I agree with perhaps cutting them down. It is a little mad, and the WYSIWYG will be here reasonably soon. —Xyrael / 19:30, 24 September 2006 (UTC)

Well, I don't think most people would know that there was discussion here. I think that this is a pretty major change, and the discussion should be more publicized. I, for one, oppose them, as they are more unnessecary clutter to the already mostly unused edit toolbar.--digital_m e^{(Talk•Contribs)} 19:31, 24 September 2006 (UTC)

I just trimmed down the options. That should make it better for low-res now.Voice-of-All 19:36, 24 September 2006 (UTC)

To disable the new buttons just add the following to your monobook.js, save, and do a hard refresh (ctrl-F5).

mwCustomEditButtons = false;

--digital_m e^{(Talk•Contribs)} 19:40, 24 September 2006 (UTC)

The table button isn't such a bad idea. But the table code produced by the form popping up needs to be improved. I wouln't want to have newbies entering such ugly defaults for tables. Hey and the template call button wasn't that bad. Too bad it has already been removed again. --Ligulem 19:42, 24 September 2006 (UTC)

I suppose we need to keep these for more bread-and-butter kind of tedious tasks, so that had to go.Voice-of-All 19:50, 24 September 2006 (UTC)

Theres a transclusion button underneath the edit box ;-) thanks/Fenton, Matthew Lexic Dark 52278 Alpha 771 19:45, 24 September 2006 (UTC)

Argh. I forgot my [4]. Thanks :) --Ligulem 19:49, 24 September 2006 (UTC)

The template button on the top of the edit window is better than the "Wiki-markup" section below the edit window. --Ligulem 19:56, 24 September 2006 (UTC)

Then can we get rid of the redundant items in the wiki markup section? Gimmetrow 20:03, 24 September 2006 (UTC)

Agree with that. But could be dangerous. I fear hordes of angry Wikipedians piling at VPT :). Removing things is always delicate... --Ligulem 20:07, 24 September 2006 (UTC)

Many of the buttons are redundant with the wiki markup section, and do we really need a javascript button just to add a ':' ? Gimmetrow 19:46, 24 September 2006 (UTC)

The ":" thing is now removed.Voice-of-All 19:50, 24 September 2006 (UTC)

I'd say it's useful for new editors. On the other hand coloured text (already removed), left-aligned and centered text are not. —Ruud 20:00, 24 September 2006 (UTC)

The : tab is rarely useful to a new editor in article space. By the time an editor runs across a need, they will have seen it on talk pages. Gimmetrow 20:03, 24 September 2006 (UTC)

True. —Ruud 20:09, 24 September 2006 (UTC)

I want to remind people that while these buttons may be very useless to most of us, they are very useful for new editors (who, obviously, have absolutely no clue how to add these buttons to their perosnal monobook.js). —Ruud 19:52, 24 September 2006 (UTC)

I am a fairly experienced WP editor. I still think the new buttons are a big help They are easier to use than the codes below the edit box, and easier than typing (or remembering) code. Individuals can quibble about whether some are more helpful than others, but that is mostly personal preference experssed by people who do know how to edit their perosnal monobook.js. Finell (Talk) 19:16, 26 September 2006 (UTC)

hem* The new JS-code looks a bit bad (I thought VoA knows JS). Look some comments from me [[5]] (and my corresponding optimized code here, you can also look at the talkpage). I've completly replaced the function marque_tab() for the table button (after all buttons be added) p.s. I've not read any discussion to this relation before, so you can hint me. --Olliminatore 12:49, 28 September 2006 (UTC)

I mainly copied these from MarkS and they seemed to be fine. If anything can be optimized, then I'd {{sofixit}}.Voice-of-All 15:23, 1 October 2006 (UTC)

I can't do that but you can look my code . Other matter: I think the center, left text align should not be used in normal articles, so remove them from standard of all (maybe <br /> too). --Olliminatore 10:18, 3 October 2006 (UTC)

[edit] Table button

I have removed the "add table" button from the toolbar. As a piece of code it is incomplete (the popup it generates is awful), and the tables it makes are equally poor. If you are going to develop new components, please submit them to the community for review and debugging before adding them to the core javascript. I don't object to have a table generator - but we can do much better than a quick hack. Thanks, ed g2s • talk 13:55, 29 September 2006 (UTC)

Here is an example of a good table:

{| class="wikitable" style="margin: 0 auto;" <!-- if centering required -->
|+ TABLE CAPTION <!-- if required -->
|-
! Heading 1
! Heading 2
! Heading 3
|-
| R1C1
| R1C2
| R1C3
|-
| R2C1
| R2C2
| R2C3
|}

Note that all background colour and other styling is (as it should be) done in the stylesheet (.wikitable). Options such as "border width" and "alternate rows" should not be provided. ed g2s • talk 14:08, 29 September 2006 (UTC)

As I noted on your talk. That button was already disabled (by me). --Ligulem 14:01, 29 September 2006 (UTC)

Cross post: Hmm, odd. It was still showing up on my toolbar. After my edit I did a hard refresh and it went away - so unless my cache was two days old (possible) - your commenting might not have been enough. Anyway, no harm done. ed g2s • talk 14:04, 29 September 2006 (UTC)

Cross post: :Yes, you did have had an outdated cache, as the button already went away thanks to my edit. I'm going to revert your edit, if you don't mind. We either disable that code on the top-most level (as I did it with my edit), or we remove that stuff completely. Keeping some brain dead code there serves not much purpose. --Ligulem 14:08, 29 September 2006 (UTC)

First a simple IE detector need to be added. If a user is using IE, then the button should be disabled. As for table appearance, anyone is welcome to fix it with something that looks prettier.Voice-of-All 20:01, 30 September 2006 (UTC)

My mentioned version has that feature, for IE (Opera too) the button makes only table sample syntax (from MarkS). (p.s. I don't tested IE for window open, because this function also don't works with my expanded function method) --Olliminatore 20:26, 30 September 2006 (UTC)

Ok I simplified the code, and it does not seem to crash IE either. The talble now uses the pretty and simple wikiclasses.Voice-of-All 20:33, 30 September 2006 (UTC)

You forgot to remove ''' ''' from TABLE CAPTION and |----- to |- --Olliminatore 10:37, 1 October 2006 (UTC)

It crashed my version of IE (IE 6) about 5 minutes ago. Someone who know how should definitely disable the button in IE until the problem is fixed. (It doesn't always crash IE, just sometimes; it's worked for me before, so testing it once in IE isn't enough to indicate the end of the problem.) 147.188.147.47

Why not just the standard control for generating a table you get in word editors, like this? That's just a demo I knocked up in half an hour, but you get the idea. ed g2s • talk 11:08, 2 October 2006 (UTC)

Wow. Cool! --Ligulem 11:20, 2 October 2006 (UTC)

Yes, that looks cool, can "you" make this function (with headline and item column option) to a corresponding popup window? That would be it. --Olliminatore 15:45, 4 October 2006 (UTC)

[edit] Archive

Just a note to all. I have archived some of the contents of this page. If anyone has any objects over this, please feel free to state your concerns. --S iva1979^{Talk to me} 04:38, 25 September 2006 (UTC)

[edit] Page not found

I propose we add:

addOnloadHook(function(){
if(document.getElementById('noarticletext')) {
var pgs = wgPageName.replace(/_/g, " ");
document.title = pgs+" - Page Not Found - Wikipedia, the free encyclopedia";
document.getElementById('searchInput').value = pgs;
}
});

Which does:

Adds a "page not found" message to the page title (which is pretty useful, because sometimes I open many pages in tabs and want to know if any are non-existant)
And adds the page title into the search box just incase someone typed something wrong and wants to fix their mistake.

GeorgeMoney (talk) 05:56, 28 September 2006 (UTC)

Both of these should be submitted to bugzilla as enhancements and implemented in PHP, not JavaScript hacks. ed g2s • talk 21:38, 7 October 2006 (UTC)

[edit] addLoadEvent versus addOnloadHook

Is there a reason that the code here doesn't use addOnloadHook that's defined in wikibits.js? Instead, addLoadEvent is defined and used. They would seem to do the same thing, but I might be missing a difference since I'm not very knowledgeable about JS. --68.142.14.91 14:59, 28 September 2006 (UTC)

I think the sequencing is in some cases, sensitive and decisively. --Olliminatore 10:11, 3 October 2006 (UTC)

[edit] Toolbar extras

The extra buttons in the toolbar, though useful, are causing serious lag in the edit page load time. I first tried adding these extra buttons (stolen from the Hebrew Wikipedia) several months back, and noticed the problem then, as did others. The problem still exists. Currently, for me at least, the toolbar takes 5+ seconds to load. — BRIAN0918 • 2006-10-11 02:25Z

I've never had them take 5 seconds, odd.Voice-of-All 04:50, 11 October 2006 (UTC)

Me neither. IIRC I noticed a very minor lag the first time they had to load (but far below 5 seconds). Since then, they are in the cache of my Firefox 1.5.0.7 (Windows XP) and everything loads immediately (I still have them right now even though they have been removed already by Brian0918, because I didn't force a cache update yet). --Ligulem 08:42, 11 October 2006 (UTC)

These should really be added back. The toolbar can be disabled via prefrences. Many other wikipedias, like RU and FR, already have such buttons. I don't see a need to remove a few very useful sitewide buttons due to one user having them take too long to load.Voice-of-All 16:21, 15 October 2006 (UTC)

Does the loading of the toolbar prevent editing? If not I don't see a problem with it loading so slowly. Even the standard toolbar can take 2 or 3 seconds to load when I'm running BitTorrent in the background. —Ruud 16:35, 15 October 2006 (UTC)

No, it just loads in the background. Actually, the bar loads near instantly, its the images that take a while sometimes, but it does not hang the page or anything, they just appear one by one.Voice-of-All 16:39, 15 October 2006 (UTC)

Please restore the extra buttons. They were very helpful. I experienced no delay in the edit box opening, and did not notice any delay in the button graphics being rendered (but a 5-second delay in that, if there was one, would not delay my editing). Finell (Talk) 07:22, 16 October 2006 (UTC)

I agree: Bring back the buttons! They are very useful, and the only delay present is caused by loading the images. Albany NY 13:22, 16 October 2006 (UTC)

I propose we add the buttons back and post a message on WP:VPT and WP:AN if anyone is experiencing the problems Brian0918 describes. Non-instantaneous loading should only happen sporadically when the images have disappeared from the browser cache, however it might also be possible that the Javascript executes too slowly one some computer/browser configurations. —Ruud 17:39, 16 October 2006 (UTC)

There is a strong concensus, in this and another item on this Talk page, for restoring the additional edit toolbar buttons. Will it be done? Finell (Talk) 20:57, 26 October 2006 (UTC)

I'd like for someone to add them back soon.Voice-of-All 22:45, 1 November 2006 (UTC)

Not a fan. Makes finding the few useful buttons (sig and redirect) harder. But I appear to be in the minority, so how can I remove these from my monobook? Should the "mwCustomEditButtons = false;" thing still work? --Spangineer^ws (háblame) 22:35, 4 November 2006 (UTC)

Seems to work, except that it doesn't remove the "make table" button. —Ruud 23:22, 5 November 2006 (UTC)

[edit] Firefox 2.0

The access keys don't work in the newly released Firefox 2.0 :( 555pt | msg | msg on w:pt 04:27, 24 October 2006 (UTC)

Use the Shift key as well. --TheParanoidOne 09:34, 24 October 2006 (UTC)

Er... Shift? If I press Shift+P in a edit box I get the P, not the preview page o.0 555pt | msg | msg on w:pt 17:27, 24 October 2006 (UTC)

You missed the "as well" part. Normally your would type Alt+P but with FF2 you need to do Shit+Alt+P. --TheParanoidOne 19:14, 24 October 2006 (UTC)

[edit] Collapsible tables fix for IE

Please make this change so that collapsible tables will display correctly in Internet Explorer:

Notes

Original code: Setting the style attribute works in Mozilla, but IE forgets it. The result was that the triangle appeared immediately to the left of the header text in IE.
Patched code: Assigning the style as an attribute forces IE to remember that the element should be floated. Mozilla ignores "styleFloat" and will still display the triangle correctly; IE ignores "cssFloat" and will still display the triangle correctly.[6]
I have tested this patch on a local, bleeding-edge copy of MediaWiki from SVN using IE6 and Ffx2: no browser recorded a javascript error.
From my experience coding this and the above source, I believe that this patch will work on all browsers.

—Cheers, DavidH Oz Au 05:58, 7 November 2006 (UTC)

I "committed" your patch. —Ruud 19:41, 7 November 2006 (UTC)

[edit] pl.wiki edit summaries

What do people think of the pl.wiki's "auto edit summary" thing? (See [7] for example, and try clicking on one of the green boxes below the edit summary field.) Is it worth implementing here? It might encourage people to use edit summaries more, because it'll be very easy to add. It will probably also help newbies who aren't sure what to type in the edit field by giving examples. —Mets501 (talk) 18:22, 7 November 2006 (UTC)

We now have that to some extent, thanks to Automatic edit summaries, which was recently checked in. What the Polish Wikipedia's doing sounds neat, though. – Minh Nguyễn (talk, contribs) 08:06, 20 November 2006 (UTC)

[edit] Initial letter is shown capitalized due to technical restrictions

frwiki has implemented a change where if you go to fr:IPod, their javascript hides the {{lowercase}} warning, and just modifies the name at the top of the page to read correctly (and it fails gracefully because the original {{lowercase}} is still shown if javascript is off). I'd like to get this working on enwiki. Many of the templates have been changed, and User:Interiot/js/RealTitle.js is working now, if included from an individual's monobook.js. I've brought up the possibility of including the change in the global monobook.js at Wikipedia:Village pump (technical)#Name technical restrictions workaround. --Interiot 08:28, 16 November 2006 (UTC)

Retrieved from "http://en.wikipedia.org../../../m/o/n/MediaWiki_talk%7EMonobook.js_f2da.html"

 var ButtonText = document.createTextNode( collapseCaption );
-Button.setAttribute( "style", "float: right;" );
+Button.style.styleFloat = "right";
+Button.style.cssFloat = "right";
 ButtonLink.setAttribute( "id", "collapseButton" + tableIndex );
 ButtonLink.setAttribute( "href", "javascript:collapseTable(" + tableIndex + ");" );